Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43988 )
Change subject: mb/google/volteer/var/halvor: Update dq/dqs mappings
......................................................................
Patch Set 6:
(2 comments)
Patch Set 6: Code-Review+2
You have 2 unresolved comments on patchset 2. You need to mark these as resolved (not just add the word "done" as a comment) before the CL can be merged.
Thanks for advise.
https://review.coreboot.org/c/coreboot/+/43988/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/halvor/memory.c:
https://review.coreboot.org/c/coreboot/+/43988/2/src/mainboard/google/voltee...
PS2, Line 10: { 3, 0, 1, 5, 4, 7, 6, 2 }, /* DDR0_DQ1[7:0] */
Done.
Ack
https://review.coreboot.org/c/coreboot/+/43988/2/src/mainboard/google/voltee...
PS2, Line 57: const struct lpddr4x_cfg *(void)
Done.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43988
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98f79283aa18f6fd41114fb6b60cac1cbed69de7
Gerrit-Change-Number: 43988
Gerrit-PatchSet: 6
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Aug 2020 06:03:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment