Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: mb/ongy/h61m-s1: Add new mainboard ......................................................................
Patch Set 24:
(12 comments)
Done with licence headers
https://review.coreboot.org/c/coreboot/+/40813/22//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40813/22//COMMIT_MSG@25 PS22, Line 25: - Tianocore payload (CorebootPayload) not works (black screen)
I wait 20 minutes and nothing happend. I don't know why it is so buggy.
Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig:
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: ## This file is part of the coreboot project.
remove
Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
this also
Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
please remove this line
Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: ## This file is part of the coreboot project.
please remove
Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
remove
Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c:
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
remove please
Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: -- This file is part of the coreboot project.
please remove
Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/gpio.c:
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
this one also
Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
remove
Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: * This file is part of the coreboot project. *
dito
Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: * This file is part of the coreboot project. */
remove
Done