Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36823 )
Change subject: soc/amd/stoneyridge/kconfig: Make Prairie Falcon selection explicit
......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6: Code-Review-1
I would prefer modifying src//stoneyridge to use the new amd_blobs repo. See CB:37119. Since cloning that requires an explicit action on the developer's part (look under General setup), all builds need to be capable of completing successfully without blobs included.
First making that change, then modifying default values is a better way to go.
I just found that the Merlin Falcon blob was already merged. So I'll remove the need for the binaries present, thus complying with your request
Someone made a mistake and only committed part of the binaries. Can't remove the request for binaries yet.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36823
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I309c5918fdc98d9927641466bbe6149b97b250f0
Gerrit-Change-Number: 36823
Gerrit-PatchSet: 6
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Nov 2019 00:47:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment