Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43401 )
Change subject: program layout: align to 64 bytes when Boot Guard is enabled
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43401/1/src/arch/x86/memlayout.ld
File src/arch/x86/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/43401/1/src/arch/x86/memlayout.ld@5...
PS1, Line 51: /* Each program stage needs to be 64 bytes aligned to be added as FIT entry */
I don't immediately see any SECTIONS declarations following the ALIGN(64) below. […]
It should align the end of the file to 64 bytes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43401
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ce09e24d716fe9845104205bc934bd2a0efc9cb
Gerrit-Change-Number: 43401
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 13 Jul 2020 10:29:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment