build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52201 )
Change subject: [WIP] mb/adlrvp: Add UART0 gpio config for ADL-M RVP ......................................................................
Patch Set 1:
(6 comments)
File src/mainboard/intel/adlrvp/early_gpio_m.c:
https://review.coreboot.org/c/coreboot/+/52201/comment/0f817725_c952743b PS1, Line 17: /* UART0 RX */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/52201/comment/a2d22d5d_a09dacb8 PS1, Line 18: PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/52201/comment/2f767973_ccea5c70 PS1, Line 18: PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/52201/comment/96926586_0baf9897 PS1, Line 19: /* UART0 TX */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/52201/comment/5a630559_e56ac300 PS1, Line 20: PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/52201/comment/c333e8d1_ef7815d4 PS1, Line 20: PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), please, no spaces at the start of a line