Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panels for Kodama
......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34505/24/src/mainboard/google/kukui...
File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/24/src/mainboard/google/kukui...
PS24, Line 24: gpio_output(GPIO(LCM_RST), 0);
: udelay(1500);
: gpio_output(GPIO(SIM2_SRST), 1);
: mdelay(5);
: gpio_output(GPIO(PERIPHERAL_EN9), 1);
: gpio_output(GPIO(MISC_BSI_CK_3), 1);
: mdelay(100);
: gpio_output(GPIO(LCM_RST), 1);
: mdelay(10);
Why is this power on sequence so different from krane or kukui?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34505
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa
Gerrit-Change-Number: 34505
Gerrit-PatchSet: 28
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicolas Boichat
drinkcat@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 04 Aug 2019 20:07:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment