Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41855 )
Change subject: soc/intel/common: add TCC activation functionality
......................................................................
Patch Set 5:
As per this below Jenkin failure :
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/131283/ : UNSTABLE
I checked these build failures and looks like these errors for majorly 3 types of systems, haswell, model_2065x and model_206ax. It looks like code is scattered across many places for these 3 platforms and difficult to address it.
So, I am thinking to use new modified function name configure_tcc_thermal_target() instead of configure_thermal_target() in common code base and use it for only for apollolake, broadwell, skylake and cannonlake possible SOCs. Kindly, suggest if you have any other inputs on this. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41855
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37dd878902b080602d70c5c3c906820613ea14a5
Gerrit-Change-Number: 41855
Gerrit-PatchSet: 5
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Puthikorn Voravootivat
puthik@chromium.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jun 2020 18:22:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment