17 Apr
2020
17 Apr
'20
2:23 p.m.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33914 )
Change subject: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes ......................................................................
Patch Set 10: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/33914/10/src/mainboard/asus/am1i-a/... File src/mainboard/asus/am1i-a/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/33914/10/src/mainboard/asus/am1i-a/... PS10, Line 29: /* AGESA nonesense: the next three headers depend on heapManager.h */ Many of the headers contributes to a mess. Some of the headers use pragmas that pack the structures etc., ugh...
--
To view, visit https://review.coreboot.org/c/coreboot/+/33914
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic096848f23910e2ad9183e44d882450ab8d4fdf1
Gerrit-Change-Number: 33914
Gerrit-PatchSet: 10
Gerrit-Owner: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Apr 2020 12:23:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment