Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36221 )
Change subject: Add configurable ramstage support for minimal PCI scanning
......................................................................
Patch Set 9:
I share Kyösti's concerns how this could be compatible to our
code for real hardware targets. Existing platform code relies
heavily on the VID/DID of PCI devices, that are never read with
this approach. So what should it be, should we hide the minimal
scanning option for all boards but those that are confirmed to
be fully compatible? Should we add a big fat warning, that this
is experimental and will break 90% of our ramstage code (and
hence, nobody should complain or even try to fix it)? Should
we remodel all of coreboot so we rely less on PCI and do things
more in a blob-style manner?
Without knowing even a coarse plan how to adapt this to exis-
ting hardware support, I really don't see how this is a step
forward. At least a hardware PoC with extensive Linux tests
(not just, it boots) would be nice. Also, if this requires
changes to the OS, do we expect upstream Linux, for instance,
to follow?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2073d9f8e9297c2b02530821ebb634ea2a5c758e
Gerrit-Change-Number: 36221
Gerrit-PatchSet: 9
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 25 Oct 2019 12:55:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment