EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )
Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37685/13/src/soc/intel/cannonlake/a...
File src/soc/intel/cannonlake/acpi/lpit.asl:
https://review.coreboot.org/c/coreboot/+/37685/13/src/soc/intel/cannonlake/a...
PS13, Line 80: OGPM
I don't understand why we need to have NVS now? Can't we just always follow the policy of saving and […]
@Furquan, this is Tim wanted. I think it okay to let mainboard can choice they want this or not.
https://review.coreboot.org/c/coreboot/+/37685/13/src/soc/intel/cannonlake/a...
PS13, Line 100: OGPM
Same question as above.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I120f8369b8d3cf7ac821332bdfa124f6ed0570e9
Gerrit-Change-Number: 37685
Gerrit-PatchSet: 13
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Sun, 22 Dec 2019 15:30:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment