Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32365 )
Change subject: coreboot: Run mainboard specific code before Cr50 reset
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32365/2/src/vendorcode/google/chromeos/cr50_...
File src/vendorcode/google/chromeos/cr50_enable_update.c:
https://review.coreboot.org/#/c/32365/2/src/vendorcode/google/chromeos/cr50_...
PS2, Line 155: likely fail at the recovery
: * screen.
fails at recovery screen? or fails verification and ends up at recovery screen?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32365
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib05c9cfde8e87daffd4233114263de5b30822872
Gerrit-Change-Number: 32365
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Mon, 22 Apr 2019 19:53:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment