8 Feb
2020
8 Feb
'20
7:22 a.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38536 )
Change subject: libpayload/corebootfb: Fix character buffer relocation ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38536/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/corebootfb.c:
https://review.coreboot.org/c/coreboot/+/38536/1/payloads/libpayload/drivers... PS1, Line 246: chars = malloc(coreboot_video_console.rows *
Before relocation, it would hold the physical == virtual location. The heap […]
Right, sorry, I guess I didn't really understand how this relocation thing works. Makes sense.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38536
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic03150f0bcd14a6ec6bf514dffe2b9153d5a6d2a
Gerrit-Change-Number: 38536
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 08 Feb 2020 06:22:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment