[coreboot-gerrit] [S] Change in coreboot[master]: lint/checkpatch: Add check for unnecessary <signed> int declarations

[Elyes Haouas (Code Review)]

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70200 )

Change subject: lint/checkpatch: Add check for unnecessary <signed> int declarations
......................................................................

lint/checkpatch: Add check for unnecessary <signed> int declarations

This reduce the difference with linux v6.1-rc7.

Change-Id: I64bbc09b531ea217514601386dd517af92aa40f1
Signed-off-by: Elyes Haouas 
---
M util/lint/checkpatch.pl
1 file changed, 32 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/70200/1

diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl
index e88461f..8756f46 100755
--- a/util/lint/checkpatch.pl
+++ b/util/lint/checkpatch.pl
@@ -4221,6 +4221,26 @@
    		     "type '$tmp' should be specified in [[un]signed] [short|int|long|long long] order\n" . $herecurr);
    	}

+# check for unnecessary <signed> int declarations of short/long/long long
+		while ($sline =~ m{\b($TypeMisordered(\s**)*|$C90_int_types)\b}g) {
+			my $type = trim($1);
+			next if ($type !~ /\bint\b/);
+			next if ($type !~ /\b(?:short|long\s+long|long)\b/);
+			my $new_type = $type;
+			$new_type =~ s/\b\s*int\s*\b/ /;
+			$new_type =~ s/\b\s*(?:un)?signed\b\s*/ /;
+			$new_type =~ s/^const\s+//;
+			$new_type = "unsigned $new_type" if ($type =~ /\bunsigned\b/);
+			$new_type = "const $new_type" if ($type =~ /^const\b/);
+			$new_type =~ s/\s+/ /g;
+			$new_type = trim($new_type);
+			if (WARN("UNNECESSARY_INT",
+				 "Prefer '$new_type' over '$type' as the int is unnecessary\n" . $herecurr) &&
+			    $fix) {
+				$fixed[$fixlinenr] =~ s/\b\Q$type\E\b/$new_type/;
+			}
+		}
+
 # check for static const char * arrays.
    	if ($line =~ /\bstatic\s+const\s+char\s**\s*(\w+)\s*[\s*]\s*=\s*/) {
    		WARN("STATIC_CONST_CHAR_ARRAY",