Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40035 )
Change subject: soc/intel/xeon_sp/cpx: Add multi-core init
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40035/6/src/soc/intel/xeon_sp/cpx/c...
File src/soc/intel/xeon_sp/cpx/chip.c:
https://review.coreboot.org/c/coreboot/+/40035/6/src/soc/intel/xeon_sp/cpx/c...
PS6, Line 4: #include <arch/acpigen.h>
Is this inclusion really necessary?
nope. addressed, thanks
https://review.coreboot.org/c/coreboot/+/40035/6/src/soc/intel/xeon_sp/cpx/c...
File src/soc/intel/xeon_sp/cpx/cpu.c:
https://review.coreboot.org/c/coreboot/+/40035/6/src/soc/intel/xeon_sp/cpx/c...
PS6, Line 64: cpu_read_topology(&num_phys, &num_virts);
Please add debug information about the number of threads and cores, as is done for other processors: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0af374ab3956009e9208917d911d29eb21db6069
Gerrit-Change-Number: 40035
Gerrit-PatchSet: 7
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Comment-Date: Thu, 02 Apr 2020 18:58:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-MessageType: comment