Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37035 )
Change subject: lib/cbmem_console.c: Drop CAR_GLOBAL_MIGRATION support
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37035/8/src/lib/cbmem_console.c
File src/lib/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/37035/8/src/lib/cbmem_console.c@67
PS8, Line 67: current_console
Any reason not to rename cbmem_console_p into current_console and replace current_console_set calls with assignments, too? The removal of current_console() leads to a weird asymmetry.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c970a07c7114bff81f0048cac8eafaec35a2386
Gerrit-Change-Number: 37035
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 29 Nov 2019 09:12:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment