Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39948 )
Change subject: nb/intel/haswell: Simplify GMA SSDT generator
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39948/4/src/northbridge/intel/haswe...
File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/39948/4/src/northbridge/intel/haswe...
PS4, Line 527: device
dev
https://review.coreboot.org/c/coreboot/+/39948/4/src/northbridge/intel/haswe...
PS4, Line 530: chip
check if this is null instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39948
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd9caf622dd4c46b13589ebb772138b25888752f
Gerrit-Change-Number: 39948
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Mar 2020 11:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment