Attention is currently required from: TimLiu-SMCI, Jonathan Zhang, Johnny Lin, Christian Walter, Jian-Ming Wang, Shelly Chang.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71958 )
Change subject: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support
......................................................................
Patch Set 7:
(3 comments)
File src/soc/intel/xeon_sp/uncore_acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169712):
https://review.coreboot.org/c/coreboot/+/71958/comment/ca4aafe5_9db4c2fb
PS7, Line 139: dev = (pds.pds[i].device_handle >> 15 ) & 0x1f;
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169712):
https://review.coreboot.org/c/coreboot/+/71958/comment/a9bd3e31_fe8fa3dd
PS7, Line 140: func = (pds.pds[i].device_handle >> 12 ) & 0x07;
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169712):
https://review.coreboot.org/c/coreboot/+/71958/comment/f828ec83_234a2ef9
PS7, Line 527: if (pciexp_find_extended_cap(dev, PCIE_EXT_CAP_ID_ATS, 0)) {
Too many leading tabs - consider code refactoring
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c436a60743bee21b3b6e4060d7874a6cdc75ecf
Gerrit-Change-Number: 71958
Gerrit-PatchSet: 7
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Comment-Date: Thu, 02 Feb 2023 09:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment