Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44026 )
Change subject: soc/intel/skylake: Enable thermal subsystem depending on devicetree
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44026/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44026/4//COMMIT_MSG@10
PS4, Line 10: but this duplicates the devicetree on/off options. Therefore use the
... depend on the devicetree for enablement ...
Done
https://review.coreboot.org/c/coreboot/+/44026/4//COMMIT_MSG@14
PS4, Line 14: matches the Device4Enable setting.
and addded missing entries
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44026
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7553716d52743c3e8d82891b2de14c52c6d8ef16
Gerrit-Change-Number: 44026
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 07 Aug 2020 21:29:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment