Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44409 )
Change subject: mb/google/volteer/halvor: Update settings for audio function
......................................................................
Patch Set 6:
please have a look at https://review.coreboot.org/c/coreboot/+/44783.
it proposes to pass the audio config hint up to the kernel based on
the audio config specified in CBI.FW_CONFIG. this means we'll need
to keep FW_CONFIG enabled. when FW_CONFIG is enabled,
volteer/fw_config.c:fw_config_handle() is going to run and as
soon as someone adds a different audio config for UP4, we'll
have to handle both cases. right now, fw_config_handle() does
nothing for halvor, so the settings in gpio.c are sufficient,
but i think this will break if we have another UP4 board that
supports multiple audio configs.
perhaps one way out is allow a compile-time (kconfig?) over-ride
for the FW_CONFIG audio DB value.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44409
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I107f6fc21b99d80d69931139dc50e7d5873a8e52
Gerrit-Change-Number: 44409
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 26 Aug 2020 02:57:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment