Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48464 )
Change subject: cpu/amd/car: Remove C source incldue of disable_cache_as_ram.c ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48464/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48464/3//COMMIT_MSG@7 PS3, Line 7: cpu/amd/car: Remove C source incldue of disable_cache_as_ram.c include
https://review.coreboot.org/c/coreboot/+/48464/3/src/cpu/amd/car/disable_cac... File src/cpu/amd/car/disable_cache_as_ram.c:
https://review.coreboot.org/c/coreboot/+/48464/3/src/cpu/amd/car/disable_cac... PS3, Line 31: static __always_inline I would guess the always_inline here is not accidental, but I did not trace this to its origins. The caller appears to be pretty much in the middle of CAR teardown, so there may have been a concern about the return address getting trashed with the entire stack in CAR.
If your target is to get fam15h back to 4.12+ you are probably going to rewrite a lot of this for POSTCAR_STAGE. Ask around what's needed before committing too much on little fixups like this. Also if you plan to support ACPI S3 suspend, to avoid low-memory corruptions (due the use of wbinvd vs invd) prepare for further complications here.