Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42282 )
Change subject: soc/intel/tigerlake: Disable hybrid storage mode in CSE Lite RO boot
......................................................................
Patch Set 15: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42282/14/src/soc/intel/tigerlake/fs...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42282/14/src/soc/intel/tigerlake/fs...
PS14, Line 260: (CONFIG(SOC_INTEL_CSE_LITE_SKU) && cse_is_hfs3_fw_sku_lite()
There is a chance CONFIG_SOC_INTEL_CSE_LITE_SKU is enabled in coreboot while CSE Consumer SKU is int […]
Done
https://review.coreboot.org/c/coreboot/+/42282/14/src/soc/intel/tigerlake/fs...
PS14, Line 261: !cse_is_hfs1_com_normal()
Thanks, I added more comments to patch#15.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5397cfc007069debe3701bf1e38e81bd17a29f0c
Gerrit-Change-Number: 42282
Gerrit-PatchSet: 15
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 Jul 2020 15:20:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jamie Ryu
jamie.m.ryu@intel.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-MessageType: comment