Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: convert SGX and PRMRR devicetree options to Kconfig ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35799/7/src/soc/intel/common/block/... File src/soc/intel/common/block/sgx/sgx.c:
https://review.coreboot.org/c/coreboot/+/35799/7/src/soc/intel/common/block/... PS7, Line 28: static bool sgx_param_valid; the file sgx.c needs to be compiled if SOC_INTEL_COMMON_BLOCK_SGX_ENABLE is y
https://review.coreboot.org/c/coreboot/+/35799/7/src/soc/intel/common/block/... PS7, Line 57: if (!CONFIG(SOC_INTEL_COMMON_BLOCK_SGX_ENABLE) || !is_sgx_supported()) that check should be in the function calling prmrr_core_configure()
https://review.coreboot.org/c/coreboot/+/35799/7/src/soc/intel/common/block/... PS7, Line 182: if (!CONFIG(SOC_INTEL_COMMON_BLOCK_SGX_ENABLE) || !is_sgx_supported() || that check should be in the code calling sgx_configure()
https://review.coreboot.org/c/coreboot/+/35799/7/src/soc/intel/common/block/... PS7, Line 213: if (!CONFIG(SOC_INTEL_COMMON_BLOCK_SGX_ENABLE) || !is_sgx_supported()) { should be in the code calling sgx_fill_gnvs()