Attention is currently required from: Paul Menzel, Paul Fagerburg, Jan Dabros.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 )
Change subject: tests: Add lib/lzma-test test case
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57555/comment/15c47e84_759f8183
PS1, Line 8:
The test output is the same as for other tests in tests/ tree. […]
Done
File tests/lib/lzma-test.c:
https://review.coreboot.org/c/coreboot/+/57555/comment/93c7709e_1d56f6ce
PS3, Line 43: 4
Make ".bin" and ".lzma.bin" into constant variables, then use strlen here instead of a magic number. […]
I did it, but instead of using strlen() I used ARRAY_SIZE(), because it includes NULL-terminator.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57555
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id75e0b41991382d4c391b031862106de58eacdf7
Gerrit-Change-Number: 57555
Gerrit-PatchSet: 4
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Mon, 04 Oct 2021 09:53:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment