Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42960 )
Change subject: mb/google/dedede: Create Drawcia Legacy variant
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede...
PS1, Line 15: select BASEBOARD_DEDEDE_LAPTOP
Marco, As Justin mentioned it is easier from a mental model standpoint that Drawcia is always 16M an […]
Done
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede...
PS1, Line 18: bool "Drawcia"
Using the same name here seems dangerous. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42960
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb5a4778abe38a396e35963a3270b0d3cc9809e0
Gerrit-Change-Number: 42960
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Jul 2020 17:49:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin TerAvest
teravest@chromium.org
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment