Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35228 )
Change subject: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to common ......................................................................
Patch Set 22:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35228/21//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35228/21//COMMIT_MSG@12 PS21, Line 12: TEST=Verified sending HECI global reset message on CML RVP & Hatch board
Please verify this on ICL and SKL platforms.
Verified on Soraka/Bobba/Hatch/CML RVP.
https://review.coreboot.org/c/coreboot/+/35228/21/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35228/21/src/soc/intel/common/block... PS21, Line 583:
Use space and not tab.
Done
https://review.coreboot.org/c/coreboot/+/35228/21/src/soc/intel/common/block... PS21, Line 585:
Use space and not tab for all members of this struct
Done
https://review.coreboot.org/c/coreboot/+/35228/21/src/soc/intel/common/block... PS21, Line 618:
print the rst_type
Not required as another debug log indicates reset type.