Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44037 )
Change subject: sconfig: Allow chipset to provide a base devicetree ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c@713 PS9, Line 713: base_root_dev
This should be chipset_root_dev in case aliases are provided by that tree. […]
base_root_dev is the chipset tree when it exists, but only if it exists.. having the first applied tree be optional makes this more difficult to deal with the naming.
the issue that did find in one of the later patches in this stack is that this doesn't account for aliases added in the override tree. ideally we'd allow multiple aliases as long as only one is probed, but that means a combination of compile-time and run-time checks.
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c@1763 PS9, Line 1763: parse_override_devicetree
the chipset device tree doesn't exist for most soc (or even non-soc for the older stuff using north/ […]
a more generic solution would be useful but I think it is going to take some effort to clean up how devices get added based on the parser calls.
it would help with the confusing naming at least when the first tree is optional.