[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge: improve indexed register helper macros

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38577 )

Change subject: nb/intel/sandybridge: improve indexed register helper macros
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38577/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38577/1//COMMIT_MSG@7 
PS1, Line 7: improve
> The bits aren't necessarily zero, hence the plus sign.

as far as i've seen apart from GDCRTRAININGRESULT which seems to be a bit of a special case here, the bits where the channel/lane/register number get shifted to are zero