Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34459 )
Change subject: payloads/tianocore: Enable UEFIPayload ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34459/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34459/5//COMMIT_MSG@14 PS5, Line 14: origin/master
origin/master
upstream/master
https://review.coreboot.org/c/coreboot/+/34459/5/payloads/external/tianocore... File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/34459/5/payloads/external/tianocore... PS5, Line 90: config TIANOCORE_BOOTLOADER : bool "TianoCore UEFI Payload" : help : UEFIPayload supports coreboot and slimboot. : IMO, would make more sense to move this to the top and make it a choice between CorebootPayloadPkg and UefiPayloadPkg, replacing the current choice between stable and git revision.
Selecting the former would set the git revision (which could be renamed) to my repo/branch, and expose the Kconfig options below (like the logo) which are specific to CorebootPayloadPkg.
Selecting the latter would set the git revision to upstream/master and hide options not relevant to UefiPayloadPkg.