Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36463 )
Change subject: soc/intel/{cnl,icl,skl}: Move sleepstates.asl into common/block/acpi
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36463/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi/sleepstates.asl:
https://review.coreboot.org/c/coreboot/+/36463/1/src/soc/intel/common/block/...
PS1, Line 17:
: Name (_S0, Package () { 0x0, 0x0, 0x0, 0x0 })
: Name (_S3, Package () { 0x5, 0x5, 0x0, 0x0 })
: Name (_S4, Package () { 0x6, 0x6, 0x0, 0x0 })
: Name (_S5, Package () { 0x7, 0x7, 0x0, 0x0 })
Those have been the same for a very long time on Intel targets? […]
got it, let me do that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36463
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie2132189f91211df74f8b5546da63ded4fdf687a
Gerrit-Change-Number: 36463
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Oct 2019 11:50:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment