Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41425 )
Change subject: [TEST] Helios: Add fan speed control for TSR3 sensor with DPTF settings
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41425/4/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/41425/4/src/mainboard/google/hatch/...
PS4, Line 93: 100
Does this mean at 50 degrees Celsius, both FAN and CPU throttle are at 100%?
My understanding is that 'Weight' is a number indicating how much of an effect (relatively speaking) a Source has on a Target. At 90C from TSR3, the fan will be running at 6700 RPM (line 57).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia545ce2c072d48a9a351fe3ad7ea66fe55f80e64
Gerrit-Change-Number: 41425
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Mengqi Guo
mqg@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Puthikorn Voravootivat
puthik@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 19 May 2020 22:15:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mengqi Guo
mqg@chromium.org
Gerrit-MessageType: comment