Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33772 )
Change subject: mb/amd/mandolin: Add Picasso CRB ......................................................................
Patch Set 43:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/acpi/gpe.asl:
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... PS42, Line 34:
I don't think we have any of these method on zork. […]
haven't investigated yet, since i didn't get the UEFI image for Mandolin to boot; if that worked, i'd just have looked at the ACPI tables from the UEFI firmware
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... PS42, Line 5: cim_verb_data
Whats all this do?
it's comsumed by src/device/azalia_device.c to configure the Azalia audio codec
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... PS42, Line 56: 0x1002
Can you use the ids from pci_ids. […]
good idea
https://review.coreboot.org/c/coreboot/+/33772/43/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/mptable.c:
PS43:
Do we care about mp tables anymore? We deleted them for zork.
not sure. I think Zheng already figured out when needs to be changed on the whole IRC config, but haven't integrated that yet