Attention is currently required from: Kyösti Mälkki.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42521 )
Change subject: mb/pcengines/apu2: Switch to proper GPIO API
......................................................................
Patch Set 14:
(1 comment)
File src/mainboard/pcengines/apu2/romstage.c:
https://review.coreboot.org/c/coreboot/+/42521/comment/e12d1ef6_0dadcd80
PS8, Line 43: gpio_output(gpio, 0);
this isn't needed any more after my common gpio patches. […]
fyi: the patch that fixed the corresponding issue in soc/amd/common is submitted now, so the workaround in here can be removed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42521
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I348ba43a76287be5b24012ae3dfc28ed783da9c7
Gerrit-Change-Number: 42521
Gerrit-PatchSet: 14
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 07 Jan 2021 19:00:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment