Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37490 )
Change subject: soc/amd/picasso: Add bootblock support
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37490/13/src/soc/amd/picasso/Kconfi...
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/37490/13/src/soc/amd/picasso/Kconfi...
PS13, Line 48: config HAVE_BOOTBLOCK
Right, instead of an empty bootblock.bin you now get full-featured non-XIP bootblock. […]
Removed bootblock from cbfs in the parent commit:
$ cbfstool /tmp/coreboot/trembyle-upstream/coreboot.rom print
FMAP REGION: COREBOOT
Name Offset Type Size Comp
cbfs master header 0x0 cbfs header 32 none
fallback/romstage 0x80 stage 82148 none
fallback/ramstage 0x141c0 stage 90638 none
config 0x2a440 raw 1524 none
revision 0x2aa80 raw 696 none
spd.bin 0x2ad80 spd 1024 none
(empty) 0x2b1c0 null 3544 none
fspm.bin 0x2bfc0 fsp 720896 none
(empty) 0xdc000 null 3992 none
fsps.bin 0xdcfc0 fsp 327680 none
pci1002,15d8.rom 0x12d000 optionrom 54272 none
fallback/dsdt.aml 0x13a480 raw 10995 none
(empty) 0x13cfc0 null 1499096 none
apu/amdfw 0x2aafc0 raw 1219584 none
(empty) 0x3d4c00 null 746456 none
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37490
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d0784025f2b39f140b16f37726d4a7f36df6c6c
Gerrit-Change-Number: 37490
Gerrit-PatchSet: 15
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 20:06:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment