[coreboot-gerrit] Change in coreboot[master]: mb/google/brya/var/kano: Update TDP PL1, PL2, and PL4 for U28 SKUs

[Sumeet R Pawnikar (Code Review)]

Attention is currently required from: David Wu, Tim Wawrzynczak, Ren Kuo, Nick Vaccaro, Alan Huang, Peter Ou.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62466 )

Change subject: mb/google/brya/var/kano: Update TDP PL1, PL2, and PL4 for U28 SKUs
......................................................................

Patch Set 3:

(3 comments)

File src/mainboard/google/brya/variants/kano/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/62466/comment/134d3210_098e1bda 
PS3, Line 134: 20000
> our thermal design target is 18~20w, we still concern the thermal event when PL1 is over the TDP so  […]

Ack

File src/mainboard/google/brya/variants/kano/ramstage.c:

https://review.coreboot.org/c/coreboot/+/62466/comment/70ce9d8b_52a3729e 
PS3, Line 10: 20000
> This change base on thermal capacity, our thermal design target is 18~20w for U28 sku. […]

Thanks Tim for adding me to the bug.

Thanks Peter for this test results.

https://review.coreboot.org/c/coreboot/+/62466/comment/f15ff05d_97fc8a6c 
PS3, Line 10: 20000
> This change base on thermal capacity, our thermal design target is 18~20w for U28 sku. […]

Ack