Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32031 )
Change subject: chromeos: update old boards to use lb_add_gpios notation
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32031/1/src/mainboard/google/peach_pit/chrom...
File src/mainboard/google/peach_pit/chromeos.c:
https://review.coreboot.org/#/c/32031/1/src/mainboard/google/peach_pit/chrom...
PS1, Line 30: {EXYNOS5_GPX3, ACTIVE_LOW, gpio_get_value(GPIO_X30), "write protect"},
line over 80 characters
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32031
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90795f32be5de881c94519933f36127098c184df
Gerrit-Change-Number: 32031
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 23 Mar 2019 04:48:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment