[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Populate EFS SPI values from Kconfig options

[Matt Papageorge (Code Review)]

Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42567 )

Change subject: soc/amd/picasso: Populate EFS SPI values from Kconfig options
......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42567/11/src/mainboard/amd/mandolin... 
File src/mainboard/amd/mandolin/Kconfig:

https://review.coreboot.org/c/coreboot/+/42567/11/src/mainboard/amd/mandolin... 
PS11, Line 13: 	select DEFAULT_SPI_READ_MODE_NORMAL_66M
> My impression is still that normal mode reads, without dummy cycles, are rarely or never supported w […]

Will have to check on this

https://review.coreboot.org/c/coreboot/+/42567/11/src/soc/amd/picasso/Kconfi... 
File src/soc/amd/picasso/Kconfig:

https://review.coreboot.org/c/coreboot/+/42567/11/src/soc/amd/picasso/Kconfi... 
PS11, Line 471: 	default 1 if SPI_MICRON_ALWAYS
> amdfwtool also has case 2 ?

This is for Renoir and other future processors