[coreboot-gerrit] Change in coreboot[master]: amd/picasso/verstage: replace rsa accel with modexp

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45987 )

Change subject: amd/picasso/verstage: replace rsa accel with modexp
......................................................................

Patch Set 5: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/45987/5/src/soc/amd/picasso/psp_ver... 
File src/soc/amd/picasso/psp_verstage/vboot_crypto.c:

https://review.coreboot.org/c/coreboot/+/45987/5/src/soc/amd/picasso/psp_ver... 
PS5, Line 122: int i;
arrsize is typed with uint32_t, to avoid signed/unsigned comparisons perhaps this should be unsigned or just uint32_t as well?

https://review.coreboot.org/c/coreboot/+/45987/5/src/soc/amd/picasso/psp_ver... 
PS5, Line 124: modulus
moduli.

https://review.coreboot.org/c/coreboot/+/45987/5/src/soc/amd/picasso/psp_ver... 
PS5, Line 153: 
trivial: trip off \n