Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42152 )
Change subject: sb/intel/bd82x6x: Use PCI bitwise ops
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42152/4/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/pcie.c:
https://review.coreboot.org/c/coreboot/+/42152/4/src/southbridge/intel/bd82x...
PS4, Line 251: /* FIXME: That ASSERT() macro contains the line number... Add padding so that it's the same */
I forgot... […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42152
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafe62d952a146bf53a28a1a83b87a3ae31f46720
Gerrit-Change-Number: 42152
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jun 2020 13:37:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment