Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49081 )
Change subject: mb/google/puff/var/dooly: Set I2C0 SerialIoDevMode to PchSerialIoPci
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG@9
PS1, Line 9: I2C0 has amplified connected, thus set it to PchSerialIoPci
Please add a period/dot at the end of sentences.
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG@9
PS1, Line 9: connected
connection?
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG@13
PS1, Line 13: TEST=Build and check DUT boot to OS
What works now?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49081
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9540f7b5538d37de53bcf43531488d714874a565
Gerrit-Change-Number: 49081
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Jan 2021 08:59:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment