Attention is currently required from: John Su, Furquan Shaikh, Martin Roth, Paul Menzel, Rob Barnes, EricR Lai.
Hello Frank Wu, build bot (Jenkins), Furquan Shaikh, Martin Roth, Kangheui Won, Paul Menzel, Rob Barnes, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49236
to look at the new patch set (#3).
Change subject: mb/google/zork/var/vilboz: Fix FW_CONFIG_SHIFT_WWAN value
......................................................................
mb/google/zork/var/vilboz: Fix FW_CONFIG_SHIFT_WWAN value
The FW config takes 2 bits for USE_FAN[27,28].
So FW_CONFIG_SHIFT_WWAN value should be 29.
BUG=b:174121847
BRANCH=zork
TEST=build vilboz
Signed-off-by: John Su john_su@compal.corp-partner.google.com
Change-Id: Ica6d04f9c48aa0800189283608bf57416ac75cf7
---
M src/mainboard/google/zork/variants/baseboard/helpers.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/49236/3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica6d04f9c48aa0800189283608bf57416ac75cf7
Gerrit-Change-Number: 49236
Gerrit-PatchSet: 3
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: newpatchset