Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38988 )
Change subject: mainboard: Add new board ASUS P8Z77-M
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38988/11/src/mainboard/asus/p8z77-m...
File src/mainboard/asus/p8z77-m/early_init.c:
https://review.coreboot.org/c/coreboot/+/38988/11/src/mainboard/asus/p8z77-m...
PS11, Line 89: /* This sequence enables early serial */
: SWITCH_TO, NCT6779D_SP1,
: PNP_IDX_EN, 0,
: PNP_IDX_IO0, CONFIG_TTYS0_BASE >> 8,
: PNP_IDX_IO0 + 1, CONFIG_TTYS0_BASE & 0xff,
: PNP_IDX_EN, 1,
See above.
No I meant that nuvoton_enable_serial is an existing function that should be called instead reimplementing it here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38988
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If756e791ddce747cb1706414be8e41e83f88922b
Gerrit-Change-Number: 38988
Gerrit-PatchSet: 13
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Aug 2020 22:01:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Gerrit-MessageType: comment