Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32535 )
Change subject: drivers/fsp 1.1: clean up Kconfig options ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32535/5/src/drivers/intel/fsp1_1/Kconfig File src/drivers/intel/fsp1_1/Kconfig:
https://review.coreboot.org/#/c/32535/5/src/drivers/intel/fsp1_1/Kconfig@54 PS5, Line 54: default 0xfff6e000 if SOC_INTEL_BRASWELL && USE_GOOGLE_FSP Frans, the SecureBoot enabled binary also has an incompatible UPD (PcdEnableSecureBoot) which I assume you'd set from your mainboard code (whatever that option does?). So I'd treat it the same as the Google FSP, here. Add a Kconfig, e.g. USE_ SECUREBOOT_FSP, and select that from your mainboard. Then we could set up matching defaults for it, too (in a follow-up).