HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34786 )
Change subject: mb/toshiba: Add A300-1ME ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34786/4/src/mainboard/toshiba/a300-... File src/mainboard/toshiba/a300-1me/blc.c:
https://review.coreboot.org/c/coreboot/+/34786/4/src/mainboard/toshiba/a300-... PS4, Line 16: #include <stdint.h> why?
https://review.coreboot.org/c/coreboot/+/34786/4/src/mainboard/toshiba/a300-... File src/mainboard/toshiba/a300-1me/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34786/4/src/mainboard/toshiba/a300-... PS4, Line 16: #include <stdint.h> : #include <stdlib.h> : #include <arch/io.h> : #include <device/device.h> : #include <drivers/intel/gma/int15.h> : #include <pc80/keyboard.h> : #include <ec/acpi/ec.h> please clean
https://review.coreboot.org/c/coreboot/+/34786/4/src/mainboard/toshiba/a300-... File src/mainboard/toshiba/a300-1me/romstage.c:
https://review.coreboot.org/c/coreboot/+/34786/4/src/mainboard/toshiba/a300-... PS4, Line 18: #include <arch/io.h> : #include <device/pnp_ops.h> : #include <device/pci_ops.h> : #include <southbridge/intel/common/gpio.h> : #include <southbridge/intel/i82801ix/i82801ix.h> : #include <northbridge/intel/gm45/gm45.h> please clean