[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configu...

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33129 )

Change subject: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configuration
......................................................................

Patch Set 15:

(3 comments)

https://review.coreboot.org/c/coreboot/+/33129/15/src/soc/intel/common/pch/t... 
File src/soc/intel/common/pch/thermal/thermal.c:

https://review.coreboot.org/c/coreboot/+/33129/15/src/soc/intel/common/pch/t... 
PS15, Line 29: static uint16_t read16p(uintptr_t addr)
             : {
             : 	return read16((void *)addr);
             : }
             : 
             : static void write16p(uintptr_t addr, uint16_t val)
             : {
             : 	write16((void *)addr, val);
             : }
These are not necessary.  A void pointer is allowed to alias any type, so below you can just call read16(...), and write16(...).

https://review.coreboot.org/c/coreboot/+/33129/15/src/soc/intel/common/pch/t... 
PS15, Line 105: read16p
See above.

https://review.coreboot.org/c/coreboot/+/33129/15/src/soc/intel/common/pch/t... 
PS15, Line 109: write16p
See above.