[coreboot-gerrit] Change in ...coreboot[master]: stage_cache: Make empty inline function if CONFIG_NO_STAGE_CACHE enable

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33394 )

Change subject: stage_cache: Make empty inline function if CONFIG_NO_STAGE_CACHE enable
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/33394/7/src/include/stage_cache.h 
File src/include/stage_cache.h:

https://review.coreboot.org/#/c/33394/7/src/include/stage_cache.h@35 
PS7, Line 35: CONFIG(CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM) \
            : 		|| CONFIG(RELOCATABLE_RAMSTAGE
> Why are these configs used here? Shouldn't it be !CONFIG(NO_STAGE_CACHE)? Or just flip it around and […]

I just went through the same thought process. This logic is mimicking the current set up. There currently isn't any dependencies tying these Kconfigs together. I think the logic is just as good (or bad) as prior to this change. It could use a clean up.