Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47990 )
Change subject: soc/intel/common/fast_spi: Add extended decode window support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47990/2/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/47990/2/src/soc/intel/common/block/... PS2, Line 277: SPI_DMI_DESTINATION_ID Looks like the compiler is complaining about this being not defined for any boards other than the TGL ones. Ugh..
What do you think about: 1. Add a function soc_get_spi_dmi_destination_id() 2. Implement this for TGL and return the appropriate value (I think this will also be helpful to handle different PCH for same SoC having different destination ID).
Then, the compiler shouldn't complain.