[coreboot-gerrit] Change in coreboot[master]: soc/intel: hook up new gpio device in the soc chips

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48583 )

Change subject: soc/intel: hook up new gpio device in the soc chips
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48583/7/src/soc/intel/alderlake/chi... 
File src/soc/intel/alderlake/chip.c:

https://review.coreboot.org/c/coreboot/+/48583/7/src/soc/intel/alderlake/chi... 
PS7, Line 202: else if (dev->path.type == DEVICE_PATH_GPIO)
             : 		dev->ops = &soc_gpio_ops;
Rather than adding this to every SoC, I think this can be handled within soc/intel/common/block/gpio driver. i.e. add something like:

static void intel_gpio_enable(struct device *dev)
{
      assert(dev->path.type == DEVICE_PATH_GPIO);
      dev->ops = &soc_gpio_ops;
}

struct chip_operations soc_gpio_ctrlr_ops = {
      CHIP_NAME("Intel GPIO controller")
      .enable_dev     = intel_gpio_enable,
}

In addition to this, you will need a chip.h in that driver.