30 Aug
2021
30 Aug
'21
1:57 p.m.
Attention is currently required from: Cliff Huang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57053 )
Change subject: mb/intel/adlrvp_m: Fix to Enable PCIe x1 Slot ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57053/comment/a3392c77_a19d1207 PS3, Line 7: mb/intel/adlrvp_m: Fix to Enable PCIe x1 Slot Please use a statement next time by adding a verb in imperative mood. [1]
[1]: https://chris.beams.io/posts/git-commit/
https://review.coreboot.org/c/coreboot/+/57053/comment/a7492739_95d3f0e5 PS3, Line 13: 00:19.0 Why is that different from 00:1d.0 from above?
--
To view, visit https://review.coreboot.org/c/coreboot/+/57053
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia988fa0b5d8fefe68503b39843aab06c4229b36f
Gerrit-Change-Number: 57053
Gerrit-PatchSet: 3
Gerrit-Owner: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Alexey Buyanov alexey.buyanov@intel.com
Gerrit-Reviewer: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Comment-Date: Mon, 30 Aug 2021 19:57:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment