Attention is currently required from: Nico Huber, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52776 )
Change subject: soc/intel/cannonlake: Rename `SOC_INTEL_COMETLAKE` ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
I would prefer not to. For coreboot, it's always just "Comet Lake" […]
Well, I don't care that much, but it would be consistent imo. I don't know the differences between these FSPs, but these options should be selected by related mainboards, while SOC_INTEL_COMETLAKE shouldn't. If we keep that name, it makes me feel it's an option like SOC_INTEL_COFFEELAKE or SOC_INTEL_KABYLAKE, which is wrong, I think.
Also, that _COMMON suffix gives the reader a hint, that there are other options depending on it and that it shouldn't be used by mainboards in general. We also have SOC_INTEL_CANNONLAKE_BASE for example..