Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31133 )
Change subject: soc/intel/cannonlake: Add Whiskeylake SoC kconfig ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/31133/8/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31133/8/src/soc/intel/cannonlake/Kconfig@267 PS8, Line 267: SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE SOC_INTEL_COMMON_CANNONLAKE_BASE? or this to accommodate for future platforms not using intel fsp git and still selects SOC_INTEL_COMMON_CANNONLAKE_BASE?